Allow returning string on getCurrentEntryId()#5746
Merged
pxpm merged 1 commit intoLaravel-Backpack:mainfrom Jan 22, 2025
Merged
Allow returning string on getCurrentEntryId()#5746pxpm merged 1 commit intoLaravel-Backpack:mainfrom
pxpm merged 1 commit intoLaravel-Backpack:mainfrom
Conversation
uuid/ulid are string based not int
|
BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly. Please keep in mind that:
Thank you! -- |
|
WHOOP-WHOOP! Congrats, your first PR on this repo has officially been merged. You should also receive an email inviting you to the Community Members team. That's where we, committed community members, debate new features and decide what's in the Backpack roadmap. Feel free to ignore the invitation if you're not interested :-) If you want to help out the community in other ways, you can:
Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-) -- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY
BEFORE - What was wrong? What was happening before this PR?
The current PHPDoc works only when using int IDs
But
uuidandulids are stringsAFTER - What is happening after this PR?
the returning type is correct, allowing also to return string (additional to the previous types)
HOW
How did you achieve that, in technical terms?
Updating the phpdoc
Is it a breaking change?
no